<br><br><div class="gmail_quote">On Wed, Aug 18, 2010 at 2:01 PM, Noah K <span dir="ltr"><<a href="mailto:bodhileok@gmail.com">bodhileok@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
On Wed, Aug 18, 2010 at 12:04 PM, Robert McNamara<br>
<div><div></div><div class="h5"><<a href="mailto:robert.mcnamara@gmail.com">robert.mcnamara@gmail.com</a>> wrote:<br>
><br>
><br>
> On Wed, Aug 18, 2010 at 11:39 AM, Robert McNamara<br>
> <<a href="mailto:robert.mcnamara@gmail.com">robert.mcnamara@gmail.com</a>> wrote:<br>
>><br>
>><br>
>> On Wed, Aug 18, 2010 at 11:34 AM, Robert McNamara<br>
>> <<a href="mailto:robert.mcnamara@gmail.com">robert.mcnamara@gmail.com</a>> wrote:<br>
>>><br>
>>><br>
>>> On Wed, Aug 18, 2010 at 11:22 AM, Noah K <<a href="mailto:bodhileok@gmail.com">bodhileok@gmail.com</a>> wrote:<br>
>>>><br>
>>>> OK, the libbluray resync (r25723, thanks Robert!) fixed the second<br>
>>>> segfault (on exit for all BDMV), but not the first (on start for<br>
>>>> some).<br>
>>>> I'll dig a little more when I have time and maybe take to<br>
>>>> libbluray-devel.<br>
>>><br>
>>> Looks like ii is ending up -1, which is likely invalid. I've reported it<br>
>>> but if I don't hear anything by the time I get home, I'll conjure up a<br>
>>> patch.<br>
>>> Robert<br>
>><br>
>> PS, If you want to try, you could see about adding something like<br>
>> if (ii <= 0) {<br>
>> return 0;<br>
>> }<br>
>> right above like 441 in clpi_parse.c, which is:<br>
>> spn = (entry->coarse[ii].spn_ep & ~0x1FFFF) + entry->fine[jj].spn_ep;<br>
>> Note that I haven't looked very close, so please forgive me if this does<br>
>> nothing at all ;)<br>
>> Robert<br>
><br>
> if you could also try changing line 380:<br>
> if (pts > timestamp) {<br>
> to<br>
> if (pts > timestamp && ii) {<br>
> I would be much obliged.<br>
> Robert<br>
><br>
<br>
</div></div>Robert, that did the trick.<br>
<br>
Turns out, though, that only one of the five movies that were<br>
segfaulting was as a result of this problem (and I had assumed they<br>
were all the same problem). The others are segfaulting even on just<br>
the m2ts file. In case you're interested:<br>
<div class="im"><br>
Program received signal SIGSEGV, Segmentation fault.<br>
</div>0xb79e5fba in HandleStreamChange (data=0xaf27200) at avformatdecoder.cpp:846<br>
846 int cnt = decoder->ic->nb_streams;<br>
<br>
But I will start a different thread for that, with the bt.<br>
Thanks for the fix!<br>
<font color="#888888">Noah<br>
</font><div><div></div><div class="h5"><br></div></div></blockquote><div><br></div><div>At least (or perhaps, unfortunately) that one is in our code. We can figure it out, though.</div><div><br></div><div>To verify, *only* the change to line 380 (the second change suggested) was necessary, right?</div>
<div><br></div><div>Robert </div></div>