<div class="gmail_quote">On Dec 6, 2007 12:08 PM, Shane <<a href="mailto:gnome42@gmail.com">gnome42@gmail.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">
<div class="Ih2E3d">On Dec 3, 2007 2:41 PM, Kevin Kuphal <<a href="mailto:kuphal@dls.net">kuphal@dls.net</a>> wrote:<br>> This is a short patch that I'm working on currently that adds the<br>> ability to set the Video Scan method in a Playgroup in order to, for
<br>> example, force interlacing for stations that broadcast a mix of<br>> progressive and interlaced frames which throws off the Auto-detector.<br>> I'm not thouroughly familiar with the interlacing setup so I'm
<br>> throwing this out there for comment. It works for me, but I'm not<br>> sure if it is the proper way of handling. What I basically did is add<br>> a method to set a default video scan type, remove the hard-coded
<br>> setting of detecting if the default type is set, and then call the<br>> function to set the scan type once the player is set up.<br>><br>> Like I said, it seems to work but I'd like another set of eyes on it
<br>> before I commit anything. This patch doesn't include it but you also<br>> just need to add an INT field of "interlacing" to the playgroup table.<br><br></div>Hi Kevin, Good idea! It was next on my list. :)
<br><br>My only suggestion: Would a tinyint be big enough for the 'interlacing' field?<br><br>Thoughts on expanded playgroup settings:<br><br>I have a patch that does the same thing for the commSkip, commNotify<br>
etc. However, I encountered a problem when implementing my patch,<br>and was thinking that the same problem might effect your patch.<br><br>The problem is that zero (0) is treated as a special value in the playgroups<br>table. Zero means 'use the value from the default playgroup', it's a nice
<br>feature that allows the user to selectively override some settings while<br>using defaults for the others.<br><br>The problem is that zero is a legitimate comm skip value (CommSkipOff = 0),<br>and I see that zero equates to kScan_Detect as well.
<br><br>I reworked things so that negative values mean 'use the default'. This<br>works fine for now but will undoubtedly be a problem later on.<br><br>So, I was hoping there might be a more robust scheme to achieve this
<br>functionality. Not sure if using NULL as the special value is an option?</blockquote>
<div> </div>
<div>Well, I think the simple way of handling it is just to use a +1 where kScan_Detect = 1 instead of zero and just subtract when converting. The code really only uses that in one place so it isn't a big change for my patch. I'm probably going to be adding another setting for Audio Sync because my NBC-HD station needs both a hard set interlacer as well as a -100ms audio delay.
</div>
<div> </div>
<div>Kevin</div></div>