[mythtv] Frontend segfault when exiting watch recordings

[Jim Westfall]

stanley kamithi <skamithi at gmail.com> wrote [12.03.06]:
> On 12/3/06, Otto Kolsi <otto at kolsi.fi> wrote:
> >
> >
> >With couple of latest SVN versions I've started to have segfault when
> >exiting from the Watch Recordings screen back to the menu. This happens:
> >
> >* with frontend only machine, cannot reproduce with frontend running
> >together with backend
> >
> >* when program playback has been activated and stopped, if I just go to
> >Watch Recordings screen and exit right back it doesn't segfault
> >
> >* also with the new Jump to Program feature, if I have selected to use
> >Watch Recordings screen
> >
> >Problem seems to be 100% reproducible. I've done 'make distclean' etc.
> >and this happens with both release and debug builds, so it should not be
> >local problem (unless ccache somehow screws my builds). I've attached
> >bactrace to this mail.
> >--
> >   Otto
> 
> 
> 
> i'll look into this tomorrow. thanks.

I was getting this as well, added some extra debug statements found the 
problem.

2006-12-03 15:31:55.615 SetPreviewGenerator(myth://10.0.0.10:6543/1112_20061129060000.mpg.png, NOT NULL)
2006-12-03 15:31:55.616 previewGenerator[/1112_20061129060000.mpg.png]
2006-12-03 15:31:55.616 Connecting to backend server: 10.0.0.10:6543 (try 1 of 5)
2006-12-03 15:31:55.617 Using protocol version 32
2006-12-03 15:31:55.774 SetPreviewGenerator(1112_20061129060000.mpg.png, NULL)
2006-12-03 15:31:55.774 previewGenerator.erase(1112_20061129060000.mpg.png)
2006-12-03 15:31:55.784 Preview: previewThreadDone took 11ms

There is an extra "/" at the beginning of the filename when adding it into 
the previewGenerator[] map.

This change fixed it for me.

Index: programs/mythfrontend/playbackbox.cpp
===================================================================
--- programs/mythfrontend/playbackbox.cpp       (revision 12183)
+++ programs/mythfrontend/playbackbox.cpp       (working copy)
@@ -3972,7 +3972,7 @@
  */
 bool PlaybackBox::SetPreviewGenerator(const QString &xfn, 
PreviewGenerator *g)
 {
-    QString fn = xfn.mid(max(xfn.findRev('/'),0));
+    QString fn = xfn.mid(xfn.findRev('/') + 1);
     if (!g)
     {
         if (previewGeneratorLock.tryLock())




jim